Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): fix invalid markdown #2290

Conversation

mroderick
Copy link
Contributor

Description

This PR fixes a minor error in the markdown of the "Using Open Feature SDKs" pages.

Before

image

After

image

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit 1bcb76f
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/66cd804e7079100008af7871
😎 Deploy Preview https://deploy-preview-2290--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thomaspoignant
Copy link
Owner

@mroderick good catch thank you 🙏🏻

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.00%. Comparing base (8f9ccb8) to head (1bcb76f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2290   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files         102      102           
  Lines        3731     3731           
=======================================
  Hits         3209     3209           
  Misses        399      399           
  Partials      123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaspoignant thomaspoignant merged commit 0a520cf into thomaspoignant:main Aug 27, 2024
20 of 22 checks passed
@mroderick mroderick deleted the fix-invalid-markdown-in-using-openfeat-sdks branch August 27, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants